Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement dummy PersistenceAdapter for TestInput #98

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

ysak-y
Copy link
Contributor

@ysak-y ysak-y commented Jan 4, 2023

Description

Implement dummy PersistenceAdapter and set it when building dummyAttributesManager object that is used in TestInput class.

Motivation and Context

Sometimes I want to use TestInput class with my actual ControlManager for e2e test. But sometimes I can't use it because of lacking persistenceAdapter in TestInput. When my implementation tries to refer persistentAttributes in AttributesManager, it raises Cannot get PersistentAttributes without PersistenceManager because there is no persistenceAdapter in TestInput.
https://github.com/alexa/alexa-skills-kit-sdk-for-nodejs/blob/2.0.x/ask-sdk-core/lib/attributes/AttributesManagerFactory.ts#L60

So I want to implement dummy persistence adapter class and introduce it to TestInput.

Testing

You can refer to and operate persistentAttributes in handler implementation when using TestInput as input of the Control.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Docs(Add new document content)
  • Translate Docs(Translate document content)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed
  • My commit message follows Conventional Commit Guideline

License

  • By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant